Take codebase in consideration when doing a 'copy' or 'export' checkout.#1291
Take codebase in consideration when doing a 'copy' or 'export' checkout.#1291sa2ajj merged 3 commits intobuildbot:masterfrom
Conversation
|
I would have honestly expected the test to break ... |
master/buildbot/steps/source/svn.py
Outdated
There was a problem hiding this comment.
'/' should be replaced by the correct platform dependant separator ... I just have no idea how to get it there ...
There was a problem hiding this comment.
os.sep. And avoid using + for string manipulation
checkout = "{}{}{}".format(checkout, so.sep, self.codebase)
There was a problem hiding this comment.
os sep will not work there, as the code is running on the master, and should be slave dependant ...
There was a problem hiding this comment.
actually, this is a good comment. what if the slave is windows?
The pattern for this is to use:
checkout_dir = self.build.slave.path_module.join(checkout_dir, self.codebase)
|
👍 Since we have this special code in place, I'd really like to see a test for it (and the fact that the test case did not fail before suggests there're not enough tests for this part). |
|
Changes Unknown when pulling 21bd446 on benallard:patch-3 into * on buildbot:master*. |
|
Actually, this code should be ... duplicated ... for each source step that implement a copy / export method ... Ouch ! Is there a way we could factorize it ? |
|
Not very specific suggestion, but did you look at |
|
I'm having troubles with the tests: |
|
Fakes are usually missing some features. You can just add the slave
|
|
The |
|
Looks like it worked ! Now waiting for Travis ... |
|
Making it work for all the steps is another story ... We need to work on unifying them first. Please merge this one, and we can open another issue about the other steps ... |
|
Changes Unknown when pulling 5de61c8 on benallard:patch-3 into * on buildbot:master*. |
|
@benallard could you please open a trac issue? |
master/svn: Take codebase in consideration when doing a 'copy' or 'export' checkout.
|
Excellent, thank you :) |
5 participants
Else, there is not much advantages of taking those mode, as the code will be fresh checked-out everytime ...