Skip to content

fix housekeeping code#1443

Merged
sa2ajj merged 3 commits intobuildbot:masterfrom
tardyp:housekeeping
Dec 15, 2014
Merged

fix housekeeping code#1443
sa2ajj merged 3 commits intobuildbot:masterfrom
tardyp:housekeeping

Conversation

@tardyp
Copy link
Copy Markdown
Member

@tardyp tardyp commented Dec 14, 2014

  • the master expiration timer was not really started
  • integration issue with the finishStep

@djmitche gave me a copy of state.sqlite of the nine.b.n server

It appears that the problem with nine.buildbot.net is that the master was changed directory, so the name has changed, and it was given another id.
The dangling builds are attached to master 1, which is already inactive. I presume that the housekeepingPR was done after.

We still need to figure out to cleanup the nine.b.n db. forcing master 1 back to active will force housekeeping code to run.

I think this would be useful to have some housekeeping commandline tool to automate these kind of tricks.

Please advise in comments

Pierre Tardy added 2 commits December 14, 2014 15:59
- the master expiration timer was not really started
- integration issue with the finishStep

Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah!

@djmitche
Copy link
Copy Markdown
Member

Looks good, but can you cherry-pick djmitche@acd95d7 in there?

@sa2ajj
Copy link
Copy Markdown
Contributor

sa2ajj commented Dec 14, 2014

For the record, I did change the directory when ansible things went right.

@sa2ajj
Copy link
Copy Markdown
Contributor

sa2ajj commented Dec 14, 2014

So it's good to merge w/ that cherry-pick?

@djmitche
Copy link
Copy Markdown
Member

As far as I'm concerned (and assuming tests pass), yes

@tardyp
Copy link
Copy Markdown
Member Author

tardyp commented Dec 14, 2014

cherry-picked djmitch test update

@tardyp tardyp removed the needs work label Dec 14, 2014
sa2ajj pushed a commit that referenced this pull request Dec 15, 2014
@sa2ajj sa2ajj merged commit 3bdf479 into buildbot:master Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants