[eight] Backport the "dynamic trigger" from nine#1636
Merged
sa2ajj merged 3 commits intobuildbot:eightfrom Apr 20, 2015
Merged
Conversation
Member
|
👍 |
master/buildbot/steps/trigger.py
Outdated
Contributor
There was a problem hiding this comment.
using exceptions as a flow control?
why not set self._all_schedulers to None and check against that?
jaredgrubb
force-pushed
the
jgrubb-backport-dyn-scheduler
branch
from
269d8ad to
f01f2d4
Compare
Member
Author
|
Adjusted the patch to address sa2ajj's comment. |
sa2ajj
pushed a commit
that referenced
this pull request
Apr 20, 2015
Backport the "dynamic trigger" from nine
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a use-case where this would be very helpful, so I backported a change made in nine by @tardyp that added "dynamic scheduler".
This is mostly the same patch, but I did have to modify it a bit to make it work with eight's scheduler stuff.
Also, I added a note about renderable properties.