Skip to content

MD: Settings page#1646

Merged
sa2ajj merged 4 commits intobuildbot:masterfrom
shanzi:md
May 5, 2015
Merged

MD: Settings page#1646
sa2ajj merged 4 commits intobuildbot:masterfrom
shanzi:md

Conversation

@shanzi
Copy link
Copy Markdown
Contributor

@shanzi shanzi commented Apr 30, 2015

Here is the settings page. Based on a similar style to about page, this page does not need much coding.

settings-preview

settings-preview-thin

NOTE: As other pages that providing settings have not been written yet, so I added a testing settings group to preview the effect. If merge with this testing group is acceptable? Please review and give your advices.

@shanzi
Copy link
Copy Markdown
Contributor Author

shanzi commented Apr 30, 2015

Live demo updated

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Apr 30, 2015

pretty cool!
waiting for @tothandras +1

@jaredgrubb
Copy link
Copy Markdown
Member

Definitely cool :)

@tothandras
Copy link
Copy Markdown
Contributor

Really nice! :)
I would keep the styles used by the view in the same folder, and when other view starts to use it then move to the shared folder.

@shanzi
Copy link
Copy Markdown
Contributor Author

shanzi commented May 2, 2015

@tothandras you mean put the setting- related styles in a separated file under /settings folder?
These styles seems to be too little to be put in standalone file. Hmmmm....

@tothandras
Copy link
Copy Markdown
Contributor

I think it's not about the size. If I would like to modify the styles related to settings, the card.less will be the last where I would look for it.

@tothandras
Copy link
Copy Markdown
Contributor

I prefer /app/settings/settings.less

On Sat, May 2, 2015, 12:25 Chase Zhang notifications@github.com wrote:

@tothandras https://github.com/tothandras OK.

Which do you think is better? Put them in /app/settings/settings.less or
/styles/settings.less?


Reply to this email directly or view it on GitHub
#1646 (comment).

@tardyp
Copy link
Copy Markdown
Member

tardyp commented May 2, 2015

Le sam. 2 mai 2015 à 13:11, András Tóth notifications@github.com a écrit :

I prefer /app/settings/settings.less

Agreed. We should document this in coffee-style.rst

@tardyp
Copy link
Copy Markdown
Member

tardyp commented May 3, 2015

actually, card.less is already shared, and make sense. I'll merge this tomorrow, if no other blockers

@tardyp tardyp added the merge-me label May 3, 2015
@shanzi
Copy link
Copy Markdown
Contributor Author

shanzi commented May 5, 2015

I think this pr is ready to be merged :)

sa2ajj pushed a commit that referenced this pull request May 5, 2015
@sa2ajj sa2ajj merged commit 0eebe48 into buildbot:master May 5, 2015
@sa2ajj
Copy link
Copy Markdown
Contributor

sa2ajj commented May 5, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants