[eight] Backport of my prior updates in Git (Pull #1649)#1655
[eight] Backport of my prior updates in Git (Pull #1649)#1655sa2ajj merged 6 commits intobuildbot:eightfrom
Conversation
There was a problem hiding this comment.
This was suggested by pylint, saying the member function had no 'self'.
There was a problem hiding this comment.
Generally interfaces don't list self, but that confuses pylint. It doesn't hurt to have self, so this is fine.
There was a problem hiding this comment.
Do we need this function at all?
There was a problem hiding this comment.
Yes, we do and it was I who wrote it :(
There was a problem hiding this comment.
do we use git_path anywhere else?
There was a problem hiding this comment.
No, it's not. the line was getting a bit long and I wanted to split it... Plus, giving things a name can help readability and make the lines easier to read.
There was a problem hiding this comment.
Sometimes it helps, and sometimes it does not.
/me is not going to argue here :)
|
Adjusted the comma as requested. |
[eight] Backport of my prior updates in Git (Pull #1649)
3 participants
This backports from the change merged in Pull #1649: