Skip to content

buildbot.status is not available in master any more#1734

Merged
tardyp merged 1 commit intobuildbot:masterfrom
sa2ajj:fix-status-plugins
Jun 24, 2015
Merged

buildbot.status is not available in master any more#1734
tardyp merged 1 commit intobuildbot:masterfrom
sa2ajj:fix-status-plugins

Conversation

@sa2ajj
Copy link
Copy Markdown
Contributor

@sa2ajj sa2ajj commented Jun 21, 2015

  • remove unnecessary interface
  • make sure reporters are exported for 'import *'

* remove unnecessary interface
* make sure reporters are exported for 'import *'
@bastien31
Copy link
Copy Markdown

In the commit message you mention that interface was removed, but /master/buildbot/interfaces.py still contains "IStatusReceiver".

@sa2ajj
Copy link
Copy Markdown
Contributor Author

sa2ajj commented Jun 22, 2015

Good point. I'll revise the patch within next couple of hours.

@sa2ajj
Copy link
Copy Markdown
Contributor Author

sa2ajj commented Jun 22, 2015

After checking the codebase, I'd say it's too early to remove the interface description: there's old status code that uses it and there are test cases for that code. I'd rather not remove the code as we want it ported to reporters API, it's just not happening now.

When the last bit is ported then it will be time to remove the interface.

@ssavrim
Copy link
Copy Markdown

ssavrim commented Jun 23, 2015

👍

@bastien31
Copy link
Copy Markdown

So if this patch is just to remove "status" and add "reporters" from init.all => 👍 (maybe update the commit message accordingly)

tardyp added a commit that referenced this pull request Jun 24, 2015
buildbot.status is not available in master any more
@tardyp tardyp merged commit a5791fc into buildbot:master Jun 24, 2015
@sa2ajj sa2ajj deleted the fix-status-plugins branch June 25, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants