Skip to content

base.py: support earlier buildbot.tac#1780

Merged
tardyp merged 1 commit intobuildbot:masterfrom
yetanotherion:fixbuildbottacreg
Aug 1, 2015
Merged

base.py: support earlier buildbot.tac#1780
tardyp merged 1 commit intobuildbot:masterfrom
yetanotherion:fixbuildbottacreg

Conversation

@yetanotherion
Copy link
Copy Markdown
Contributor

@yetanotherion yetanotherion commented Jul 21, 2015

Fixes
http://trac.buildbot.net/ticket/3318
that created a regression introduced by
201f0d9

the regression being buildbot not supporting
buildbot.tac files containing
print someString
lines anymore.

@jaredgrubb
Copy link
Copy Markdown
Member

jaredgrubb commented Jul 21, 2015

As an advocate for the devil here, maybe asking people to update these files is a good thing? It may be this is the only Py3-compatible change we will make here, but if there are others, letting them not update could be a problem.

But I dont have an objection to this.

@djmitche
Copy link
Copy Markdown
Member

djmitche commented Jul 21, 2015

Agree, looking forward, buildbot.tac should be python-3 compatible too. The error seems to be fairly self-explanatory, so perhaps just a release note would do the trick?

I suspect most users don't have a print statement in their tac files.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 21, 2015

Current coverage is 84.07%

Merging #1780 into master will not affect coverage as of a684b18

@@            master   #1780   diff @@
======================================
  Files          314     314       
  Stmts        30635   30635       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          25755   25755       
  Partial          0       0       
  Missed        4880    4880

Review entire Coverage Diff

Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#379...412
  2. +0.10% via ...ot/status/builder.py#451...479
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov

@yetanotherion yetanotherion force-pushed the fixbuildbottacreg branch 2 times, most recently from f251a52 to 81f9cfa Compare July 22, 2015 08:06
@yetanotherion
Copy link
Copy Markdown
Contributor Author

yetanotherion commented Jul 22, 2015

@djmitche @jaredgrubb as per your reviews, the code was removed and the release note updated

tardyp
tardyp reviewed Jul 22, 2015
View reviewed changes
master/docs/relnotes/0.9.0b1.rst Outdated
Copy link
Copy Markdown
Member

@tardyp tardyp Jul 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a specific comment that this is even if you are in a python 2.x runtime

@yetanotherion yetanotherion force-pushed the fixbuildbottacreg branch 2 times, most recently from 46ecec9 to cf80f75 Compare July 22, 2015 13:51
@yetanotherion
Copy link
Copy Markdown
Contributor Author

yetanotherion commented Jul 22, 2015

@tardyp note about python2.x added

relnotes: buildbot.tac should use print as function
cf80f75 
print as statements are not supported in buildbot.tac
anymore.
http://trac.buildbot.net/ticket/3318

This commit writes that in the release note.
@tardyp
Copy link
Copy Markdown
Member

tardyp commented Aug 1, 2015

👍

tardyp added a commit that referenced this pull request Aug 1, 2015
@tardyp
Merge pull request #1780 from yetanotherion/fixbuildbottacreg
d951059 
base.py: support earlier buildbot.tac
@tardyp tardyp merged commit d951059 into buildbot:master Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yetanotherion @jaredgrubb @djmitche @codecov-io @tardyp @sa2ajj