Skip to content

interfaces: isRenderable#1841

Closed
yetanotherion wants to merge 1 commit intobuildbot:masterfrom
yetanotherion:isRenderable
Closed

interfaces: isRenderable#1841
yetanotherion wants to merge 1 commit intobuildbot:masterfrom
yetanotherion:isRenderable

Conversation

@yetanotherion
Copy link
Copy Markdown
Contributor

Method to compute whether an object
is renderable.

@codecov-io
Copy link
Copy Markdown

Current coverage is 84.53%

Merging #1841 into master will decrease coverage by -0.02% as of 6ba08a6

@@            master   #1841   diff @@
======================================
  Files          320     320       
  Stmts        31108   31116     +8
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          26302   26305     +3
  Partial          0       0       
- Missed        4806    4811     +5

Review entire Coverage Diff as of 6ba08a6


Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#381...414
  2. +0.10% via ...ot/status/builder.py#453...481
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

Method to compute whether an object
is renderable.
@sa2ajj
Copy link
Copy Markdown
Contributor

sa2ajj commented Sep 8, 2015

Do we already have users for this method?

@jaredgrubb
Copy link
Copy Markdown
Member

Looks good, but a unit test or two could be good.

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Sep 18, 2015

after digging, it looks like this patch is needed by workdir renderable patch we have on our old buildbot eight. After discussing with the devs, I believe that the isRenderable is not really needed. @yetanotherion if you agree, please close

@yetanotherion
Copy link
Copy Markdown
Contributor Author

all:
sorry for the noise, have a good day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants