publish bower for buildbot-data#1893
Conversation
|
@tothandras the publish scripts for buildbot-data, adapted from guanlecoja-ui |
www/data_module/README.md
Outdated
There was a problem hiding this comment.
I usually use symlink instead, so I don't have to copy it every time I change something.
There was a problem hiding this comment.
are you sure this works?
guanlecoja is supposed to erase the dist directory at startup, which will delete your symlink.
There was a problem hiding this comment.
my workflow looks something like this:
- run
gulp prodin base (dependencies are installed) - run
gulp prodin data - create symlink
- run
gulp dev proxyin base - run
gulp devin data
On Mon, Oct 26, 2015, 17:15 Pierre Tardy notifications@github.com wrote:
In www/data_module/README.md
#1893 (comment):@@ -25,3 +25,17 @@ $ gulp
$ npm install
$ karma start+ +## How to test within buildbot/www/base ? + +``` +$ cp dist/* ../base/libs/buildbot-data/dist/are you sure this works?
guanlecoja is supposed to erase the dist directory at startup, which will
delete your symlink.—
Reply to this email directly or view it on GitHub
https://github.com/buildbot/buildbot/pull/1893/files#r43014702.
|
@tardyp looks good |
Current coverage is
|
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
|
shall we merge this? |
|
Looks good! |
Fixes for the js build scripts, and add publish version
I used this script to push a new tag
https://github.com/buildbot/buildbot-data-js/tree/1.0.15