Skip to content

publish bower for buildbot-data#1893

Merged
tardyp merged 2 commits intobuildbot:masterfrom
tardyp:publishbower
Nov 3, 2015
Merged

publish bower for buildbot-data#1893
tardyp merged 2 commits intobuildbot:masterfrom
tardyp:publishbower

Conversation

@tardyp
Copy link
Copy Markdown
Member

@tardyp tardyp commented Oct 24, 2015

Fixes for the js build scripts, and add publish version

I used this script to push a new tag

https://github.com/buildbot/buildbot-data-js/tree/1.0.15

@tardyp
Copy link
Copy Markdown
Member Author

tardyp commented Oct 24, 2015

@tothandras the publish scripts for buildbot-data, adapted from guanlecoja-ui

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use symlink instead, so I don't have to copy it every time I change something.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this works?

guanlecoja is supposed to erase the dist directory at startup, which will delete your symlink.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my workflow looks something like this:

  1. run gulp prod in base (dependencies are installed)
  2. run gulp prod in data
  3. create symlink
  4. run gulp dev proxy in base
  5. run gulp dev in data

On Mon, Oct 26, 2015, 17:15 Pierre Tardy notifications@github.com wrote:

In www/data_module/README.md
#1893 (comment):

@@ -25,3 +25,17 @@ $ gulp
$ npm install
$ karma start

+
+## How to test within buildbot/www/base ?
+
+```
+$ cp dist/* ../base/libs/buildbot-data/dist/

are you sure this works?

guanlecoja is supposed to erase the dist directory at startup, which will
delete your symlink.


Reply to this email directly or view it on GitHub
https://github.com/buildbot/buildbot/pull/1893/files#r43014702.

@tothandras
Copy link
Copy Markdown
Contributor

@tardyp looks good

@codecov-io
Copy link
Copy Markdown

Current coverage is 84.57%

Merging #1893 into master will not affect coverage as of 12378d6

@@            master   #1893   diff @@
======================================
  Files          320     320       
  Stmts        31106   31106       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          26307   26307       
  Partial          0       0       
  Missed        4799    4799       

Review entire Coverage Diff as of 12378d6


Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#381...414
  2. +0.09% via ...ot/status/builder.py#453...481
  3. +0.09% via ...dbot/changes/mail.py#478...505
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

Signed-off-by: Pierre Tardy <tardyp@gmail.com>
@tardyp
Copy link
Copy Markdown
Member Author

tardyp commented Oct 30, 2015

shall we merge this?

@tothandras
Copy link
Copy Markdown
Contributor

Looks good!

tardyp added a commit that referenced this pull request Nov 3, 2015
publish bower for buildbot-data
@tardyp tardyp merged commit 1dfdc0c into buildbot:master Nov 3, 2015
@tardyp tardyp deleted the publishbower branch April 24, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants