Remove the getPendingBuildTimes method from base scheduler

[MikeLing]

This PR is about tickets 2653, which required remove no longer used method from base scheduler. Due to the discussion under the ticket and the comment in here, I just remove the getPendingBuildTimes method :)

[codecov-io]

Current coverage is 83.85%

Merging #2008 into master will not affect coverage as of 230f6dc

@@            master   #2008   diff @@
======================================
  Files          321     321       
  Stmts        31490   31488     -2
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          26405   26403     -2
  Partial          0       0       
  Missed        5085    5085       

Review entire Coverage Diff as of 230f6dc

---

Uncovered Suggestions

1. +0.10% via ...ot/status/builder.py#381...414
2. +0.09% via ...ot/status/builder.py#453...481
3. +0.08% via ...dbot/changes/mail.py#478...505
4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

[djmitche]

This is good so far, but I see a lot more places this method is used and defined. Try git grep getPendingBuildTimes (git grep is an awesome tool!)

[tardyp]

git grep shows a few code more to kill

[tardyp]

Hi mike. do you want to finish this?

[MikeLing]

Oh yes, sorry for the late reply! I will commit this PR ASAP!!

[MikeLing]

@djmitche @tardyp Sorry for the late reply, I somehow miss the notification email until this weekend. Sorry :(

Yeah I know we still have some more getPendingBuildTimes functions, but they are not for the BaseScheduler class. Should we remove them all? It only ask to remove getPendingBuildTimes methods from BaseScheduler in the issue description.

[djmitche]

Yes, please remove all of them -- the request implied all BaseScheduler subclasses, too :)

[tardyp]

👍 keeping it a bit for others to review