Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @tothandras to be a potential reviewer |
_.template has changed args (no need for null anymore)
In case of race conditions, sometimes step 1 is seen before step2
Member
Author
|
did verify that this works for me (had to fix a bunch of things though) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are very near the release, we won't be able to upgrade that much our JS dependencies, as people will start to create code against it.
I upgraded guanlecoja-ui to latest version of its dependencies, and here is the needed code in bb in order to have it working under those new deps
https://github.com/buildbot/guanlecoja-ui#changelog
I still need to test that heavily beyond unit tests as we are far from 100% coverage.