Skip to content

Bump angularjs dependencies#2127

Merged
tardyp merged 9 commits intobuildbot:masterfrom
tardyp:bump
Apr 29, 2016
Merged

Bump angularjs dependencies#2127
tardyp merged 9 commits intobuildbot:masterfrom
tardyp:bump

Conversation

@tardyp
Copy link
Copy Markdown
Member

@tardyp tardyp commented Apr 17, 2016

As we are very near the release, we won't be able to upgrade that much our JS dependencies, as people will start to create code against it.

I upgraded guanlecoja-ui to latest version of its dependencies, and here is the needed code in bb in order to have it working under those new deps

https://github.com/buildbot/guanlecoja-ui#changelog

  • 1.6.0: Massive upgrade of dependencies:
    • jquery 2.1 -> 2.2.
    • Angular 1.4 -> 1.5.
    • Lodash -> 4.11.
    • Drop underscore.string as lodash got most important string utils.
    • angular-ui-bootstrap 0.11 -> 1.3.2: Most important change is that ui-bootstrap directives are now prefixed with "uib-" e.g: in jade: ".dropdown-toggle" -> ".dropdown-toggle(uib-dropdown-toggle)" This makes the markup more complicated, but the old 0.11 documentation is not even available anymore, so its best to upgrade.

I still need to test that heavily beyond unit tests as we are far from 100% coverage.

@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @tothandras to be a potential reviewer

tardyp and others added 7 commits April 24, 2016 18:00
_.template has changed args (no need for null anymore)
make sure all the different packages have same version
In case of race conditions, sometimes step 1 is seen before step2
@tardyp
Copy link
Copy Markdown
Member Author

tardyp commented Apr 24, 2016

did verify that this works for me (had to fix a bunch of things though)

@tardyp tardyp merged commit ce9e136 into buildbot:master Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants