.travis.yml: put lint tests first#2215
Conversation
More than 20 travis jobs are currently executed to validate a pull request. Travis however doesn't start the 20 builds in parallel. The link tests are therefore executed after previous ones are finished. To avoid situations where all the unit tests are ok, but one needs to wait 20 minutes to be aware of a lint issue (incorrect order of import), which is quite likely to happen, this commit puts the lint test first. Change-Id: Id57d6d9fec4742cc7ea768d888e058835ebb2113
|
I'd probably move coverage and docs up there as well to catch things like spelling errors and poorly formatted rst more quickly. |
|
yes, I have been wanting to do that for long |
|
agree, please also put doc first. |
Put coverage and docs tests up, to catch related errors earlier. Change-Id: Id4df0d304afed5cc742b7c386aa2cfca182512a9
yetanotherion
force-pushed
the
lint_test_first
branch
from
ccaa4c7 to
beb0805
Compare
|
@tardyp @ryansydnor I put docs and coverage up |
|
@ryansydnor @djmitche @tardyp the patch does not seem to work |
|
It looks like the newer PRs (perhaps those that are rebased on top of your change) are behaving as expected. (for example, https://travis-ci.org/buildbot/buildbot/builds/129687285) I realized that this change could make the builds even more efficient (from both a time and resource perspective) if we fail fast. Fortunately travis gives us that capability! I've opened another PR here: #2226 |
6 participants
More than 20 travis jobs are currently
executed to validate a pull request. Travis
however doesn't start the 20 builds in parallel.
The link tests are therefore executed after
previous ones are finished.
To avoid situations where all the unit tests are ok,
but one needs to wait 20 minutes to be aware
of a lint issue (incorrect order of import), which is quite likely
to happen, this commit puts the lint test first.
Change-Id: Id57d6d9fec4742cc7ea768d888e058835ebb2113