Fix invocation of trial on Windows with Twisted 16.4.0#2373
Merged
tardyp merged 1 commit intobuildbot:masterfrom Aug 28, 2016
rodrigc:appveyor
Merged
Fix invocation of trial on Windows with Twisted 16.4.0#2373tardyp merged 1 commit intobuildbot:masterfrom rodrigc:appveyor
tardyp merged 1 commit intobuildbot:masterfrom
rodrigc:appveyor
Conversation
|
@rodrigc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @tomprince, @rutsky and @anish to be potential reviewers |
%PYTHON%\\Scripts\trial.py is gone in Twisted 16.4.0. In Twisted 16.4.0, trial was converted to a Python console script. It must be invoked as "trial" or "python -m twisted.trial".
Current coverage is 86.65% (diff: 100%)@@ master #2373 diff @@
==========================================
Files 294 294
Lines 30549 30549
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 26471 26471
Misses 4078 4078
Partials 0 0
|
|
someone knows why "python -m trial" is better than just trial, just for my information? |
Contributor
Author
|
"python -m twisted.trial" is equivalent, it is not better or worse. |
|
ok thx :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Twisted 16.4.0, trial was converted to a Python console
script. It must be invoked as "trial" or "python -m twisted.trial".
%PYTHON%\Scripts\trial.py is gone in Twisted 16.4.0.