GerritChangeSource: avoid logging of unecessary messages.#3036
Merged
tardyp merged 1 commit intobuildbot:masterfrom Mar 11, 2017
Merged
GerritChangeSource: avoid logging of unecessary messages.#3036tardyp merged 1 commit intobuildbot:masterfrom
tardyp merged 1 commit intobuildbot:masterfrom
Conversation
Currently GerritChangeSource log a message for every received event that doesn't have a type or which isn't set to be handled. This pollute the log file with unecessary messages. This change enable logging of these messages only when debug is set True.
Codecov Report
@@ Coverage Diff @@
## master #3036 +/- ##
==========================================
- Coverage 87.5% 87.49% -0.01%
==========================================
Files 313 313
Lines 33092 33199 +107
==========================================
+ Hits 28956 29047 +91
- Misses 4136 4152 +16
Continue to review full report at Codecov.
|
tardyp
approved these changes
Mar 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently GerritChangeSource log a message for every
received event that doesn't have a type or which
isn't set to be handled. This pollute the log file
with unecessary messages.
This change enable logging of these messages only when
debug is set True.