Skip to content

GerritChangeSource: avoid logging of unecessary messages.#3036

Merged
tardyp merged 1 commit intobuildbot:masterfrom
wainersm:gerrit_change_source
Mar 11, 2017
Merged

GerritChangeSource: avoid logging of unecessary messages.#3036
tardyp merged 1 commit intobuildbot:masterfrom
wainersm:gerrit_change_source

Conversation

@wainersm
Copy link
Copy Markdown
Contributor

Currently GerritChangeSource log a message for every
received event that doesn't have a type or which
isn't set to be handled. This pollute the log file
with unecessary messages.

This change enable logging of these messages only when
debug is set True.

Currently GerritChangeSource log a message for every
received event that doesn't have a type or which
isn't set to be handled. This pollute the log file
with unecessary messages.

This change enable logging of these messages only when
debug is set True.
@mention-bot
Copy link
Copy Markdown

@wainersm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @sa2ajj and @jvlomax to be potential reviewers.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2017

Codecov Report

Merging #3036 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage    87.5%   87.49%   -0.01%     
==========================================
  Files         313      313              
  Lines       33092    33199     +107     
==========================================
+ Hits        28956    29047      +91     
- Misses       4136     4152      +16
Impacted Files Coverage Δ
master/buildbot/changes/gerritchangesource.py 74.64% <ø> (+0.46%)
master/buildbot/process/factory.py 64.4% <0%> (-1.25%)
master/buildbot/process/remotetransfer.py 95.08% <0%> (+3.22%)
worker/buildbot_worker/commands/base.py 36.64% <0%> (+5.92%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0ec03...2c92cdc. Read the comment docs.

@seankelly seankelly closed this Mar 11, 2017
@seankelly seankelly reopened this Mar 11, 2017
@tardyp tardyp merged commit b316f2b into buildbot:master Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants