fix missing status_to_string convertion#3091
Merged
tardyp merged 2 commits intobuildbot:masterfrom Apr 20, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3091 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 314 314
Lines 32987 32987
=======================================
Hits 29135 29135
Misses 3852 3852Continue to review full report at Codecov.
|
seankelly
approved these changes
Apr 1, 2017
Member
seankelly
left a comment
seankelly
left a comment
There was a problem hiding this comment.
Test are failing because they want the import in a different order. I'm assuming the buildbot import should be in a separate group like you have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trivial fix reported on irc, I forgot to push