Skip to content

[docs] Fix Apache reverse proxy config#3299

Merged
tardyp merged 1 commit intobuildbot:masterfrom
Frodox:patch-5
Jun 8, 2017
Merged

[docs] Fix Apache reverse proxy config#3299
tardyp merged 1 commit intobuildbot:masterfrom
Frodox:patch-5

Conversation

@Frodox
Copy link
Copy Markdown
Member

@Frodox Frodox commented Jun 6, 2017

  • I have updated the appropriate documentation

@mention-bot
Copy link
Copy Markdown

@Frodox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @sa2ajj and @gracinet to be potential reviewers.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2017

Codecov Report

Merging #3299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         320      320           
  Lines       33292    33292           
=======================================
  Hits        29367    29367           
  Misses       3925     3925

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00150e3...06f4631. Read the comment docs.

@Frodox
Copy link
Copy Markdown
Member Author

Frodox commented Jun 7, 2017

Just found that it breaks #3174. What is correct way to resolve it? Should I add one more config for CentOS/RHEL/Fedora?
Should I add configs into some examples dir?
According to ws-apache-docs ProxyPass should match some Path (as in nginx config), like

ProxyPass "/ws2/"  "ws://echo.websocket.org/"
ProxyPass "/wss2/" "wss://echo.websocket.org/"

current one

ProxyPass ws://127.0.0.1:8020/ws

can't be working one because it doesn't match any path. So it can be only like

ProxyPass /ws ws://127.0.0.1:8020/ws

@Frodox Frodox changed the title add apache reverse proxy config for CentOS 7 Fix Apache reverse proxy config Jun 7, 2017
@Frodox Frodox changed the title Fix Apache reverse proxy config [docs] Fix Apache reverse proxy config Jun 7, 2017
@Frodox
Copy link
Copy Markdown
Member Author

Frodox commented Jun 7, 2017

from conversation to #3174 it looks like it wrong PR.
Should there be

ProxyPass /ws !

now?

@gracinet
Copy link
Copy Markdown

gracinet commented Jun 7, 2017

Agh sorry for the mess, indeed I failed the copy-paste from my running systems. The /ws is indeed missing, that line should have been:

       ProxyPass /ws ws://localhost:8011/ws
      ProxyPassReverse /ws ws://localhost:8011/ws

ProxyPass /ws !, together with gets back to the prior version, that didn't work for me on Debian 9, hence motivating the prior change.

Just adding the missing /ws would probably be simpler than enclosing in a (and would match what I have in production on Debian 8 and 9). If that also works for you, then I'd prefer it

@Frodox
Copy link
Copy Markdown
Member Author

Frodox commented Jun 7, 2017

@gracinet what is meaning of ProxyPass /ws ! ? So, should it be returned with note about Debian9 ? What happens without this option?

@gracinet
Copy link
Copy Markdown

gracinet commented Jun 7, 2017

I works, without ProxyPass /ws ! for both Debian 8 and 9, but I did not test it with the re-added

That ! directive is meant to prevent proxying the given URI, and could be used at some point to dispatch between non-proxied / differently proxied nested locations. Everything looks as if its scope changed between the two Debian versions, and it started blocking also what was in <Location /ws>

@tardyp tardyp merged commit becf821 into buildbot:master Jun 8, 2017
@tardyp
Copy link
Copy Markdown
Member

tardyp commented Jun 8, 2017

thanks guys!

@Frodox Frodox deleted the patch-5 branch June 14, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants