Skip to content

[docs] db - minor unification#3491

Merged
tardyp merged 2 commits intobuildbot:masterfrom
Frodox:patch-1
Aug 8, 2017
Merged

[docs] db - minor unification#3491
tardyp merged 2 commits intobuildbot:masterfrom
Frodox:patch-1

Conversation

@Frodox
Copy link
Copy Markdown
Member

@Frodox Frodox commented Aug 3, 2017

  • I have updated the appropriate documentation

@mention-bot
Copy link
Copy Markdown

@Frodox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sa2ajj, @prasoon2211 and @tychoish to be potential reviewers.

1 similar comment
@mention-bot
Copy link
Copy Markdown

@Frodox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sa2ajj, @prasoon2211 and @tychoish to be potential reviewers.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2017

Codecov Report

Merging #3491 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         323      323           
  Lines       33720    33720           
=======================================
  Hits        29760    29760           
  Misses       3960     3960

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb06720...ea8714a. Read the comment docs.

@seankelly
Copy link
Copy Markdown
Member

Could you fix the DbConfig page too? It has:

c['db_url'] = 'mysql://user@pass:mysqlserver/buildbot'

The @ and : need to be swapped.

@Frodox
Copy link
Copy Markdown
Member Author

Frodox commented Aug 4, 2017

ah, of course. Fixed

@Frodox
Copy link
Copy Markdown
Member Author

Frodox commented Aug 5, 2017

Can we write about sqlite in memory case also here? sqlite://

@rjarry is it ready enough to use/test it?:)

@tardyp tardyp merged commit a4850b7 into buildbot:master Aug 8, 2017
@tardyp
Copy link
Copy Markdown
Member

tardyp commented Aug 8, 2017

Can we write about sqlite in memory case also here? sqlite://

Need to be very very clear that this is only for development, or if you like to loose your data!

@Frodox Frodox deleted the patch-1 branch August 8, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants