Skip to content

Fixed null value of steps and logs in reporter HttpStatusPush api#3710

Merged
tardyp merged 1 commit intobuildbot:masterfrom
timqi:master
Oct 26, 2017
Merged

Fixed null value of steps and logs in reporter HttpStatusPush api#3710
tardyp merged 1 commit intobuildbot:masterfrom
timqi:master

Conversation

@timqi
Copy link
Copy Markdown
Contributor

@timqi timqi commented Oct 22, 2017

fix #3180

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2017

Codecov Report

Merging #3710 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3710      +/-   ##
==========================================
+ Coverage   88.45%   88.45%   +<.01%     
==========================================
  Files         323      323              
  Lines       34001    34002       +1     
==========================================
+ Hits        30076    30077       +1     
  Misses       3925     3925
Impacted Files Coverage Δ
master/buildbot/reporters/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e1bdd...4879c38. Read the comment docs.

Copy link
Copy Markdown
Member

@tardyp tardyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a little bit more insight in the commit log?
test raising the problem would be great, and newsfragment is necessary

@timqi
Copy link
Copy Markdown
Contributor Author

timqi commented Oct 23, 2017

This commit fixes the issue that null value of steps and logs of HttpStatusPush reporter api, reported at #3180 . may no new features added. Hope can be merged and repack in pip

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Oct 23, 2017

@timqi please use git commit --amend in order to add this info into the git commit log.

newsfragments are also for bug fixes. please add one as described here: https://github.com/buildbot/buildbot/blob/master/master/buildbot/newsfragments/README.txt

I am afraid I will not do a release just for this fix, but this fix will be included in the next release which is due for beginning of november.

thanks for you contibution and effort to follow our process!

@timqi timqi changed the title fix #3180 Fixed null value of steps and logs in reporter HttpStatusPush api Oct 24, 2017
@tardyp tardyp merged commit 6ed16c1 into buildbot:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot get steps via HttpStatusPush

2 participants