Fixed null value of steps and logs in reporter HttpStatusPush api#3710
Fixed null value of steps and logs in reporter HttpStatusPush api#3710tardyp merged 1 commit intobuildbot:masterfrom timqi:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3710 +/- ##
==========================================
+ Coverage 88.45% 88.45% +<.01%
==========================================
Files 323 323
Lines 34001 34002 +1
==========================================
+ Hits 30076 30077 +1
Misses 3925 3925
Continue to review full report at Codecov.
|
tardyp
left a comment
There was a problem hiding this comment.
Can you please add a little bit more insight in the commit log?
test raising the problem would be great, and newsfragment is necessary
|
This commit fixes the issue that null value of steps and logs of HttpStatusPush reporter api, reported at #3180 . may no new features added. Hope can be merged and repack in pip |
|
@timqi please use git commit --amend in order to add this info into the git commit log. newsfragments are also for bug fixes. please add one as described here: https://github.com/buildbot/buildbot/blob/master/master/buildbot/newsfragments/README.txt I am afraid I will not do a release just for this fix, but this fix will be included in the next release which is due for beginning of november. thanks for you contibution and effort to follow our process! |
fix #3180