config: check for duplicate service names#3814
Merged
tardyp merged 1 commit intobuildbot:masterfrom Dec 27, 2017
Merged
Conversation
Contributor
Author
|
The flake errors seem unrelated to my changes. Is this PR good for merge? |
Most services have a default 'name' attribute. When instantiating the same service class multiple times (e.g. multiple email notifiers), if the user does not override the name, only the last service is actually configured. Make sure that all services have a unique name. Signed-off-by: Robin Jarry <robin@jarry.cc>
rjarry
force-pushed
the
duplicate-services
branch
from
1afb761 to
a487b31
Compare
Codecov Report
@@ Coverage Diff @@
## master #3814 +/- ##
==========================================
+ Coverage 88.49% 88.49% +<.01%
==========================================
Files 323 323
Lines 34059 34062 +3
==========================================
+ Hits 30139 30142 +3
Misses 3920 3920
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most services have a default
nameattribute. When instantiating the same service class multiple times (e.g. multiple email notifiers), if the user does not override the name, only the last service is actuallyconfigured.
Make sure that all services have a unique name.
Fixes #3813
master/buildbot/newsfragmentdirectory (and read theREADME.txtin that directory)