Webpackoja preparation: embed guanlecoja-ui, remove ng-classify, vendor frontend dependencies#4046
Webpackoja preparation: embed guanlecoja-ui, remove ng-classify, vendor frontend dependencies#4046tardyp wants to merge 6 commits intobuildbot:masterfrom
Conversation
rjarry
left a comment
rjarry
left a comment
There was a problem hiding this comment.
I'm not sure to understand the "unclassify" commit. Could you add a small commit message?
this commit is a run of ng-classify on all the coffeescript we have https://github.com/CaryLandholt/ng-classify This allows to release the dependency on obsolete ng-classify, so that we are only dependent on coffeescript
Codecov Report
@@ Coverage Diff @@
## master #4046 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 326 326
Lines 34330 34330
=======================================
Hits 30402 30402
Misses 3928 3928Continue to review full report at Codecov.
|
tardyp
changed the title
|
@rjarry here is my attempt at vendoring the bower dependencies |
We keep only the files of interrest in order to not commit too much stuff
|
@rjarry I have now modified buildbot_pkg to build the javascripts with python instead of gulp. It still needs coffee-script node-uglifyjs and node-less installed to build. The problem with this solution is that it will be obsolete as soon as we merge #4056 from @uglycoyote and start using webpack, because we start using require(), and then we will depend on webpack to build. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
closing due to our stalled pull request policy |
3 participants
For now, this is only for main UI.
@rjarry