Fix several build request collapsing bugs#6152
Merged
p12tic merged 4 commits intobuildbot:masterfrom Jul 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6152 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 348 348
Lines 37315 37328 +13
=======================================
+ Hits 34295 34308 +13
Misses 3020 3020
Continue to review full report at Codecov.
|
Closed
7f89282 to
4d6375c
Compare
|
Thanks for this! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection of 3 bug fixes in the default build request collapsing functionality. The collapsed build requests are not seen anywhere in the UI, so to the end users it would look like as if the schedulers were the broken piece.
Fixes #4686. Fixes #3762. Fixes #4642.
Contributor Checklist:
master/buildbot/newsfragmentsdirectory (and read theREADME.txtin that directory)