Skip to content

Fix several build request collapsing bugs#6152

Merged
p12tic merged 4 commits intobuildbot:masterfrom
p12tic:buildrequest-collapsing-bugs
Jul 29, 2021
Merged

Fix several build request collapsing bugs#6152
p12tic merged 4 commits intobuildbot:masterfrom
p12tic:buildrequest-collapsing-bugs

Conversation

@p12tic
Copy link
Copy Markdown
Member

@p12tic p12tic commented Jul 28, 2021

This PR is a collection of 3 bug fixes in the default build request collapsing functionality. The collapsed build requests are not seen anywhere in the UI, so to the end users it would look like as if the schedulers were the broken piece.

Fixes #4686. Fixes #3762. Fixes #4642.

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragments directory (and read the README.txt in that directory)
  • n/a I have updated the appropriate documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 28, 2021

Codecov Report

Merging #6152 (4d6375c) into master (2c1428f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6152   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         348      348           
  Lines       37315    37328   +13     
=======================================
+ Hits        34295    34308   +13     
  Misses       3020     3020           
Impacted Files Coverage Δ
master/buildbot/db/model.py 92.06% <ø> (ø)
master/buildbot/process/buildrequest.py 96.08% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1428f...4d6375c. Read the comment docs.

@p12tic p12tic mentioned this pull request Jul 28, 2021
@p12tic p12tic force-pushed the buildrequest-collapsing-bugs branch from 7f89282 to 4d6375c Compare July 28, 2021 23:54
@p12tic p12tic merged commit a5222da into buildbot:master Jul 29, 2021
@p12tic p12tic deleted the buildrequest-collapsing-bugs branch July 29, 2021 00:11
@mwild1
Copy link
Copy Markdown

mwild1 commented Jul 29, 2021

Thanks for this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants