add two examples of methods for daylighting and glare simulations#179
Merged
Conversation
…ngle values in arrays (when the schema allows multiple values and thus requires arrays), using the valid format for UUIDs (for example, characters like `s` may not occur in UUIDs), and adding missing commata
simonwacker
added a commit
that referenced
this pull request
Feb 4, 2021
simonwacker
added a commit
that referenced
this pull request
Feb 4, 2021
simonwacker
force-pushed
the
add-daylight-method-examples
branch
from
eff95ab to
76de9e9
Compare
simonwacker
force-pushed
the
add-daylight-method-examples
branch
from
76de9e9 to
f9bd4e8
Compare
simonwacker
approved these changes
Feb 4, 2021
Contributor
simonwacker
left a comment
simonwacker
left a comment
There was a problem hiding this comment.
I added three commits to make the JSON files valid JSON (there were commata missing), to make them valid with respect to the schema schemas/method.json (there were some data type errors, for example, a string value instead of an array containing one string value), and to link this pull request in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #144