Create a JSON schema for life cycle data by christoph-maurer · Pull Request #335 · building-envelope-data/api

christoph-maurer · 2024-10-16T14:28:58Z

The new domain lifeCycle shall cover three topics: lifeCycleAssessment, circularity and compliance. The structure of lifeCycleAssessment and circularity is based on a structure of Madaster. The structure of compliance was developed by EPEA part of Drees&Sommer. The JSON Schema lifeCycleData.json was developed by EPEA and Fraunhofer ISE. It shall include all data which is typically relevant to use life cycle data.

As the data structure is already being used, the JSON Schema is not ideal. #358 collects the topics which are strongly recommended to be improved as soon as it is possible.

christoph-maurer

@pascalkeppler Thank you for the very good first draft of the schema! Please add commits to this branch to address the comments and let me know whenever you have questions!

christoph-maurer · 2025-07-15T07:45:35Z

@aklefenz @pascalkeppler Thanks for the commits! Please let me know when you have resolved all comments of the first review. Then I start the second review.

christoph-maurer

@pascalkeppler @aklefenz Thank you for the substantial improvement! I have fixed what I was able to fix in a day.

Please resolve the 16 comments of this second review. 11 comments are new. 5 comments are from the first review. I have marked only the old ones with @pascalkeppler @aklefenz .

aklefenz · 2025-09-04T08:11:23Z

Hi @christoph-maurer thanks for the reviews. I implemented all the feedback of your reviews, wherever possible, and resolved all comments.

…est data and implement changes from review comments

…es": false

…tems" a `"uniqueItems": true`"

christoph-maurer · 2025-09-10T07:33:10Z

@simon-wacker I have reviewed the pull request. Unfortunately, it is already in use. I have collected my recommendations for future improvements in #358 . Do you want to review the pull request?

simonwacker

I only had a quick glance and no deep understanding of the schema or the subject domain.

simonwacker · 2025-09-10T11:16:45Z

+        "functionalUnit": {
+          "type": "string",
+          "enum": [
+            "Volume",


For consistency with other enums in the repository use lower camel-case.

Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

simonwacker · 2025-09-10T11:20:05Z

+          "type": "number",
+          "description": "Terrestrial ecotoxicity potential (TETP) (kg 1,4-Dichlorobenzene)"
+        },
+        "pere": {


Such abbreviations or acronyms make it hard for me to read (and understand).

Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

simonwacker · 2025-09-10T11:21:29Z

+              "type": "boolean",
+              "description": "The product is used as a base coat"
+            },
+            "VocContentPerLiter": {


Should be lower camel-case. Also above and below.

Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

simonwacker · 2025-09-10T11:25:27Z

+              "enum": ["n.v.", "0", "1", "2", "3", "3.1", "3.2", "4", "5"]
+            },
+            "OnlyConstructiveWoodProtection": {
+              "type": "boolean",


I'm wondering if those flags could be modeled more elegantly and if they are any interrelations. A more elegant way may be an enumeration for mutually exclusive elements of a similar kind.

Thanks for the feedback. Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

simonwacker · 2025-09-10T11:28:23Z

+              "description": "A full declaration of product ingredients is publicly available. ",
+              "enum": [
+                "n.v.",
+                "available with all CAS numbers",


Using spaces and . makes it difficult to parse those enum members in languages like C# or Java because the enumerations there do not allow these characters. Rather use an expressive lower camel-case string with a-Z0-9 characters and add the description of those in a more readable form in the description of the enum. This also applies to other enums in this file.

Thanks for the valuable feedback. Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

simonwacker · 2025-09-10T11:28:54Z

+              "type": "string",
+              "description": "All substances in the product have been classified according to the Greenscreen Benchmark approach for safer chemicals",
+              "enum": [
+                "n.v.",


I am wondering what n.v. stands for? no value? Anyway, I would avoid such abbreviations.

Unfortunately it is already in use and we cannot change it, at least now. Discussed with Christoph to add it to future improvements

christoph-maurer · 2025-09-10T11:42:35Z

Thank you @simon-wacker !

@aklefenz @pascalkeppler Can you please resolve the conversations of @simon-wacker's review?

simonwacker · 2025-09-11T09:21:31Z

"Already in use" I see. Too bad. Please don't reply with the same message to all conversations. I'm a human and don't want to read it so often. And I'm a bit edgy right now (also very human).

christoph-maurer · 2025-09-11T09:48:57Z

"Already in use" I see. Too bad. Please don't reply with the same message to all conversations. I'm a human and don't want to read it so often. And I'm a bit edgy right now (also very human).

@simon-wacker It's my fault. I should have explained the background before asking you for a review. I have asked @aklefenz to separate the recommendations for improvements in three categories.

Some keys are part of a format developed and used by the company Madaster. We want to collect our proposals for improvement in an issue, but it is difficult to change.
Other keys are currently being used only by EPEA in a product database. We want to collect our proposals for improvement in a second issue so that they can be implemented for example next year.
@aklefenz promised to implement all recommendations which are not affected by 1. and 2.

We can talk about it in our next meeting. Sorry for the bad organization!

aklefenz · 2025-09-11T12:01:26Z

@christoph-maurer I implemented the feedback wherever possible and pushed my commit. I left the comments open where there is sth to add to future improvements.

christoph-maurer · 2025-09-11T12:09:10Z

Thank you, @aklefenz ! Which part is based on keys of Madaster?

aklefenz · 2025-09-11T12:17:38Z

@christoph-maurer everything from circularity and lifeCycleAssessment is based on Madaster

christoph-maurer added the ISE Fraunhofer Institute for Solar Energy Systems ISE label Oct 16, 2024

christoph-maurer self-assigned this Oct 16, 2024

christoph-maurer force-pushed the life-cycle-schema branch from e36036f to 9265a94 Compare February 12, 2025 15:43

christoph-maurer commented Mar 5, 2025

View reviewed changes

christoph-maurer commented Mar 24, 2025

View reviewed changes

Comment thread tests/valid/lifeCycleData/lifeCycleTest.json Outdated

christoph-maurer force-pushed the life-cycle-schema branch from f2af931 to 5947640 Compare August 5, 2025 12:38

christoph-maurer commented Aug 6, 2025

View reviewed changes

christoph-maurer and others added 15 commits September 4, 2025 15:33

First step of creating a JSON schema for life cycle data

d785f11

First attempt to add lifecycle schema

49da1d3

Status February 12th

5240076

Delete old files cradleToCradle

ce44909

Fix some bugs regarding testing

517e3fd

Fix more bugs

0117c2e

Fix last bugs

d79a6c4

Added Compliance aspects. Fixed som Metainfo

d37f632

Add life cycle compliance data

8366390

Update life cycle compliance schema and add test data

e606ac1

Merge different life cycle files into one

b5d9505

lca schema refinements, update valid lca test data, add invalid lca t…

acc17ac

…est data and implement changes from review comments

make format

b4398ed

Exchange cradleToCradle by lifeCycle

1c0553a

Tests against data.json failed because of missing "additionalProperti…

d7392d8

…es": false

christoph-maurer force-pushed the life-cycle-schema branch from f1cc170 to d18029a Compare September 4, 2025 13:35

christoph-maurer added 5 commits September 4, 2025 15:36

dataPoints in opticalData.json must be unique

e74154e

Each "properties" needs a "additionalProperties": false and each "i…

5f18358

…tems" a `"uniqueItems": true`"

make format

fabcdec

Update the tests so that 2/3 succeed

5ce2703

Add compliance next to circularity and lifeCycleAssessment

9c1166e

christoph-maurer and others added 9 commits September 4, 2025 15:36

Update description of lifeCycleData.json

8c74c95

Exchange data set by dataset

fb0baba

Fix typo in database.graphql

6751ded

Fix more typos in /apis/

41c337e

Implement feedback from code review

d18029a

Describe the meaning of the phase A1_A3

4850a23

Decribe the meaning of the UUID

9c5ff32

Fix reference of "sm" to kilogram

7d56b29

Turn the requirements Ra and Raout-in into lower camel case.

c684e55

simonwacker requested changes Sep 10, 2025

View reviewed changes

implement further feedback

903038e

Update CHANGELOG

68b280b

christoph-maurer merged commit 8040504 into develop Sep 15, 2025

christoph-maurer deleted the life-cycle-schema branch September 15, 2025 12:35

github-project-automation Bot moved this from 🆕 New to ✅ Done in EQWIN-P Sep 15, 2025

Conversation

christoph-maurer commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christoph-maurer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christoph-maurer commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christoph-maurer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aklefenz commented Sep 4, 2025

Uh oh!

christoph-maurer commented Sep 10, 2025

Uh oh!

simonwacker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

christoph-maurer commented Sep 10, 2025

Uh oh!

simonwacker commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christoph-maurer commented Sep 11, 2025

Uh oh!

aklefenz commented Sep 11, 2025

Uh oh!

christoph-maurer commented Sep 11, 2025

Uh oh!

christoph-maurer commented Oct 16, 2024 •

edited

Loading

christoph-maurer commented Jul 15, 2025 •

edited

Loading

simonwacker commented Sep 11, 2025 •

edited

Loading