Conversation
aothms
left a comment
There was a problem hiding this comment.
Nice
Two questions:
- how is this hooked into e.g github actions? I don't see any changes there or reference to the new makefile entries
- where does the slowness come from?
e2e/tests/validate.test.js
Outdated
| @@ -0,0 +1,34 @@ | |||
| const { test, expect } = require('@playwright/test'); | |||
There was a problem hiding this comment.
Minor thing, but should we use?
| const { test, expect } = require('@playwright/test'); | |
| import { test, expect } from '@playwright/test'; |
(and rename file to .mjs probably)
At least that's what I'm used to in 2025, but I guess it's not a very significant thing here
There was a problem hiding this comment.
Agree - we should switch that in all UI's, maybe at package.json level and keep .js extensions?
There was a problem hiding this comment.
Yes, looks like we need to keep *.js extensions as the tests do not get discovered with .mjs.
It's not in GH Actions yet - this PR will add e2e scaffolding and sample tests, next is integration in CI/CD pipeline
I assume spinning up Django with migrations - locally it takes 15s to start frontend/backend and 2s to run 3 tests We could speed it up by actually testing against the Docker images |
Or we could cache the environment setup to speed things up. |
Run locally with
make e2e-test