Skip to content

IVS-31 - Added Playwright tests#205

Merged
civilx64 merged 5 commits intodevelopmentfrom
IVS-31_Add_Playwright_e2e_Scaffolding
Jul 30, 2025
Merged

IVS-31 - Added Playwright tests#205
civilx64 merged 5 commits intodevelopmentfrom
IVS-31_Add_Playwright_e2e_Scaffolding

Conversation

@rw-bsi
Copy link
Contributor

@rw-bsi rw-bsi commented Jul 23, 2025

  • Playwright scaffolding
  • 2 example test scenarios (one Django Admin, one Validate UI)

Run locally with make e2e-test

@rw-bsi rw-bsi requested review from Ghesselink and civilx64 July 23, 2025 20:01
@rw-bsi rw-bsi self-assigned this Jul 23, 2025
Copy link
Collaborator

@aothms aothms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Two questions:

  • how is this hooked into e.g github actions? I don't see any changes there or reference to the new makefile entries
  • where does the slowness come from?

@@ -0,0 +1,34 @@
const { test, expect } = require('@playwright/test');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but should we use?

Suggested change
const { test, expect } = require('@playwright/test');
import { test, expect } from '@playwright/test';

(and rename file to .mjs probably)

At least that's what I'm used to in 2025, but I guess it's not a very significant thing here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - we should switch that in all UI's, maybe at package.json level and keep .js extensions?

https://nodejs.org/docs/latest/api/packages.html#type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like we need to keep *.js extensions as the tests do not get discovered with .mjs.

@rw-bsi
Copy link
Contributor Author

rw-bsi commented Jul 24, 2025

Nice

Two questions:

  • how is this hooked into e.g github actions? I don't see any changes there or reference to the new makefile entries

It's not in GH Actions yet - this PR will add e2e scaffolding and sample tests, next is integration in CI/CD pipeline
(see here for example Scorecards pipeline)

  • where does the slowness come from?

I assume spinning up Django with migrations - locally it takes 15s to start frontend/backend and 2s to run 3 tests
(see here for again Scorecards CI/CD integration example - bulk is packages and browsers)

We could speed it up by actually testing against the Docker images

@civilx64
Copy link
Contributor

We could speed it up by actually testing against the Docker images

Or we could cache the environment setup to speed things up.

@civilx64 civilx64 merged commit f7d1daf into development Jul 30, 2025
3 checks passed
@civilx64 civilx64 deleted the IVS-31_Add_Playwright_e2e_Scaffolding branch July 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants