Merged
Conversation
Ghesselink
temporarily deployed
to
development
GitHub Actions
Inactive
Ghesselink
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously prevented PRs to push to DEV (#216). However, this change also stopped the testing within pull requests, which is quite useful.
Taking another look at it, we were probably not actually pushing to DEV. Because of
if: github.event_name == 'push'within 'deploy'. Github doesn't seem to treat pull requests as pushes (only in case of direct pushes todevelopment). The naming ('Build & Deploy', for pr's as well as pushes to dev) made it confusing however, so splitting it up into two separate workflows is a little verbose but perhaps clearer.