Skip to content

API Pagination - Bugfixes#232

Merged
Ghesselink merged 4 commits intodevelopmentfrom
gh_pagination_fixes
Sep 21, 2025
Merged

API Pagination - Bugfixes#232
Ghesselink merged 4 commits intodevelopmentfrom
gh_pagination_fixes

Conversation

@Ghesselink
Copy link
Contributor

  • e2e tests

@rw-bsi
Copy link
Contributor

rw-bsi commented Sep 18, 2025

Getting an error (sometimes, not always...) - maybe b/c of parallel test workers?
It works when I run that single test all by itself. Maybe the data has changed between the two requests.

image

@Ghesselink
Copy link
Contributor Author

Getting an error (sometimes, not always...) - maybe b/c of parallel test workers?
It works when I run that single test all by itself. Maybe the data has changed between the two requests.

@rw-bsi
That was indeed what was going on. Fix was to run it using
test.describe.serial
95d6f8e

@rw-bsi
Copy link
Contributor

rw-bsi commented Sep 21, 2025

@Ghesselink please look at latest commit - not using describe.serial anymore, not reliable - if you're happy, we can merge it and close PR?

@Ghesselink
Copy link
Contributor Author

@Ghesselink please look at latest commit - not using describe.serial anymore, not reliable - if you're happy, we can merge it and close PR?

@rw-bsi
Looks good :-) Fixed some ugly merge conflicts and will merge it now. It's also very nice to have this merged for the e2e github integration.

@Ghesselink Ghesselink merged commit 91443d3 into development Sep 21, 2025
2 checks passed
@Ghesselink Ghesselink deleted the gh_pagination_fixes branch September 21, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants