Skip to content

allowlisting testfiles, unit test and small ui change#288

Merged
Ghesselink merged 21 commits intodevelopmentfrom
tfk-allowlisting-testfiles
Apr 28, 2026
Merged

allowlisting testfiles, unit test and small ui change#288
Ghesselink merged 21 commits intodevelopmentfrom
tfk-allowlisting-testfiles

Conversation

@aothms
Copy link
Copy Markdown
Collaborator

@aothms aothms commented Mar 17, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@Ghesselink Ghesselink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this took be a bit to figure out. The allowlisting tests are the first e2e tests that require validation to complete in CI. We never had a Celery worker running there, and all previous tests happened to pass without one. I've added a worker and pre-seeded the dev user to suppress the self-declaration dialog, after that the tests failed.

There was a side effect of adding a celery worker: three existing tests in validate_api.test.js have a broken assertion toHaveProperty('request') that was silently passing before because no worker meant the loops never executed. Now that validation actually runs, this assertion fails. I've temporarily used eager mode to keep CI green.

Still needs a separate fix in validate_api.test.js, but shouldn't block this PR I'd say.

@Ghesselink Ghesselink merged commit eb4f298 into development Apr 28, 2026
3 checks passed
@Ghesselink Ghesselink deleted the tfk-allowlisting-testfiles branch April 28, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants