allowlisting testfiles, unit test and small ui change#288
allowlisting testfiles, unit test and small ui change#288Ghesselink merged 21 commits intodevelopmentfrom
Conversation
Ghesselink
left a comment
There was a problem hiding this comment.
Ok, this took be a bit to figure out. The allowlisting tests are the first e2e tests that require validation to complete in CI. We never had a Celery worker running there, and all previous tests happened to pass without one. I've added a worker and pre-seeded the dev user to suppress the self-declaration dialog, after that the tests failed.
There was a side effect of adding a celery worker: three existing tests in validate_api.test.js have a broken assertion toHaveProperty('request') that was silently passing before because no worker meant the loops never executed. Now that validation actually runs, this assertion fails. I've temporarily used eager mode to keep CI green.
Still needs a separate fix in validate_api.test.js, but shouldn't block this PR I'd say.
No description provided.