ci(windows): add windows-latest to test matrix (non-blocking)#353
Open
Huntehhh wants to merge 1 commit into
Open
ci(windows): add windows-latest to test matrix (non-blocking)#353Huntehhh wants to merge 1 commit into
Huntehhh wants to merge 1 commit into
Conversation
Doubles the test matrix to Windows on every PR — runs the same 4 Python versions (3.10-3.13) on both Linux and Windows for 8 jobs total. Marked continue-on-error on Windows so failures show as visible signal without blocking PR merges, since several in-flight PRs (buildingjoshbetter#344 fcntl/WNOHANG, buildingjoshbetter#345 hooks guard, buildingjoshbetter#351 subprocess portability, buildingjoshbetter#352 test helper) need to land before Windows can flip to required. Net effect: every open PR (buildingjoshbetter#344 buildingjoshbetter#345 buildingjoshbetter#346 buildingjoshbetter#347 buildingjoshbetter#348 buildingjoshbetter#349 buildingjoshbetter#350 buildingjoshbetter#351 buildingjoshbetter#352) starts getting Windows regression coverage on review immediately, with zero source dependencies. Flip continue-on-error off once the green baseline holds across two consecutive main-branch runs. Co-Authored-By: claude-opus-4-7 <wontreply@getfucked.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
windows-latestto the CI test matrix on every PR — 4 Python versions × 2 OSes = 8 jobs. Windows is markedcontinue-on-errorso failures show up as visible signal on PR reviews without blocking merges. The block flips off once #344 (fcntl/WNOHANG), #345 (hooks fcntl guard), #351 (subprocess portability), and #352 (test helper hardening) all land — after that, a green-on-Windows main run for two cycles in a row should be the gate to removecontinue-on-errorand make Windows required.Zero source dependencies. Order-independent vs every other open PR. Recommended to merge first so every other in-flight PR (#344 #345 #346 #347 #348 #349 #350 #351 #352) starts getting Windows regression coverage immediately on review.
Changes
.github/workflows/ci.ymlos: [ubuntu-latest, windows-latest]to matrix · changeruns-on: ubuntu-latest→runs-on: ${{ matrix.os }}· addcontinue-on-error: ${{ matrix.os == 'windows-latest' }}with inline comment explaining the temporary non-blocking postureTest plan
build-checkjob unchanged (still ubuntu-only, 3.12 only, as designed for packaging signal)continue-on-errorin a follow-upCo-Authored-By: claude-opus-4-7 wontreply@getfucked.ai