Discover artifact bucket region using S3 manager API#1495
Merged
keithduncan merged 4 commits intomainfrom Aug 31, 2021
Merged
Conversation
If BUILDKITE_S3_DEFAULT_REGION is non-empty it is set to that, otherwise it is set to the result of awsRegion()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the provided region to discover the actual region.
This handles the cross region case where a pipeline’s
AWS_DEFAULT_REGIONpoints somewhere other than the bucket region.Fixes https://github.com/buildkite/agent/pull/new/keithduncan/artifact-cross-region