Skip to content

Write "unknown exit status" in expanded section#2783

Merged
DrJosh9000 merged 3 commits into
mainfrom
unknown-exit-status-expando
May 16, 2024
Merged

Write "unknown exit status" in expanded section#2783
DrJosh9000 merged 3 commits into
mainfrom
unknown-exit-status-expando

Conversation

@DrJosh9000
Copy link
Copy Markdown
Contributor

@DrJosh9000 DrJosh9000 commented May 15, 2024

Description

Improve the messaging when running in the Kubernetes stack when one of the other containers never connect to the "server" container socket.

Context

https://linear.app/buildkite/issue/PENT-50/investigate-the-difficulty-of-showing-more-descriptive-error-messages

Changes

  • Put the existing error message in a new pre-expanded section, so it's not hidden inside another section accidentally
  • Tweak the wording (ImagePullBackoff = container image couldn't be pulled)
  • Drive-by improvement to the Await loop to make the sleep context-aware
  • Drive-by improvement to an error string (%q)

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 marked this pull request as ready for review May 15, 2024 07:33
@DrJosh9000 DrJosh9000 force-pushed the unknown-exit-status-expando branch from 666617e to 0740e30 Compare May 15, 2024 07:33
@DrJosh9000 DrJosh9000 requested a review from a team May 15, 2024 07:33
Copy link
Copy Markdown
Contributor

@SorchaAbel SorchaAbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrJosh9000 DrJosh9000 merged commit 3df7ada into main May 16, 2024
@DrJosh9000 DrJosh9000 deleted the unknown-exit-status-expando branch May 16, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants