Merged
Conversation
DrJosh9000
force-pushed
the
update-install-sh
branch
2 times, most recently
from
a80ca86 to
129dea0
Compare
DrJosh9000
force-pushed
the
update-install-sh
branch
2 times, most recently
from
10fe604 to
8a8380d
Compare
DrJosh9000
force-pushed
the
update-install-sh
branch
from
8a8380d to
4530d85
Compare
swaller-bk
approved these changes
Oct 10, 2024
swaller-bk
left a comment
swaller-bk
left a comment
There was a problem hiding this comment.
Tested on darwin amd64, I was able to use the releases dir to trigger the checksum check, nice work!
This was referenced Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
install.sh is in need of some love. I borrowed some ideas from https://getmic.ro
Context
https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Pipelines-In-Progress-Board_suIFKYEb#Escalations-Pipelines_tuQbCBf6/r732&view=modal
Changes
mktemp -d, and a cleanup trapTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)