Merged
Conversation
CerealBoy
approved these changes
Oct 17, 2024
This was referenced Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set headers in the request that S3 is happy with.
Content-Rangeisn't necessary for the request (it was a flourish I added for debugging purposes), andTransfer-Encodingis added by Go whenContentLengthisn't set.Context
Testing showed that AWS rejects
Content-RangeandTransfer-Encodingheaders with 501 Not Implemented.Changes
Content-Rangereq.ContentLengthTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)