Validate ping mode flag, tweak log levels#3734
Merged
DrJosh9000 merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
DrJosh9000
force-pushed
the
improve-auto-mode-logging
branch
3 times, most recently
from
48b3a19 to
58bce84
Compare
zhming0
reviewed
Mar 4, 2026
DrJosh9000
force-pushed
the
improve-auto-mode-logging
branch
6 times, most recently
from
d3a07c9 to
cbfe9c4
Compare
DrJosh9000
force-pushed
the
improve-auto-mode-logging
branch
from
cbfe9c4 to
2480514
Compare
DrJosh9000
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate that
ping-modeis set to an acceptable value, and rename "ping-only" to "poll-only". ("ping-only" still accepted.)Avoid logging an error when configured in auto ping mode, but still log an info message in case someone has selected auto mode deliberately and is expecting streaming to work.
Context
https://buildkite-corp.slack.com/archives/C07KJ0ZSNN9/p1772593581819329
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
A quick, entirely human-brained, PR.