fix: prevent snapshot logic if command phase isn't included#3825
Merged
DrJosh9000 merged 1 commit intomainfrom Apr 15, 2026
Merged
fix: prevent snapshot logic if command phase isn't included#3825DrJosh9000 merged 1 commit intomainfrom
DrJosh9000 merged 1 commit intomainfrom
Conversation
zhming0
approved these changes
Apr 15, 2026
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
LGTM with a comment on doc
DrJosh9000
force-pushed
the
a-1073-require-command-phase
branch
from
114c0f5 to
7a91f67
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #3789: require the command phase in the current executor to be included for the snapshot logic to trigger.
Context
Codex actually made a good point in #3789.
https://linear.app/buildkite/issue/A-1073
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I did the typing manually.