Skip to content

A-1130: fix --glob-resolve-follow-symlinks regression#3828

Merged
zhming0 merged 1 commit intomainfrom
ming/a-1130
Apr 17, 2026
Merged

A-1130: fix --glob-resolve-follow-symlinks regression#3828
zhming0 merged 1 commit intomainfrom
ming/a-1130

Conversation

@zhming0
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 commented Apr 17, 2026

Fixes #3826

Problem

buildkite-agent artifact upload --glob-resolve-follow-symlinks "**/*" fails to descend into symlinked directories. When a glob pattern fully matches a symlink path (e.g. **/* matches a/b/c), zzglob returns immediately after the callback without falling through to the symlink traversal code — so the directory behind the symlink is never walked.

Fix

Upgrade drjosh.dev/zzglob from v0.4.2 to v0.4.3, which fixes the early-return bug in walkDirFunc for fully-matched directory symlinks.

The upstream fix is in DrJosh9000/zzglob#19

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Disclosures / Credits

Me and my LLM minion

@zhming0 zhming0 requested review from a team as code owners April 17, 2026 05:47
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​drjosh.dev/​zzglob@​v0.4.2 ⏵ v0.4.3100100100100100

View full report

@zhming0 zhming0 enabled auto-merge April 17, 2026 05:53
@zhming0 zhming0 merged commit 54b47b9 into main Apr 17, 2026
3 checks passed
@zhming0 zhming0 deleted the ming/a-1130 branch April 17, 2026 05:55
@zhming0 zhming0 mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

artifact upload --glob-resolve-follow-symlinks fails to traverse symlinked directories for some upload patterns

2 participants