A-1130: fix --glob-resolve-follow-symlinks regression#3828
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
quinn-diesel
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3826
Problem
buildkite-agent artifact upload --glob-resolve-follow-symlinks "**/*"fails to descend into symlinked directories. When a glob pattern fully matches a symlink path (e.g.**/*matchesa/b/c), zzglob returns immediately after the callback without falling through to the symlink traversal code — so the directory behind the symlink is never walked.Fix
Upgrade
drjosh.dev/zzglobfrom v0.4.2 to v0.4.3, which fixes the early-return bug inwalkDirFuncfor fully-matched directory symlinks.The upstream fix is in DrJosh9000/zzglob#19
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Me and my LLM minion