Skip to content

feat: migrate to github.com/klauspost/compress/gzip for optimized deflate#3832

Merged
wolfeidau merged 1 commit intomainfrom
feat_use_klauspost_compress
Apr 20, 2026
Merged

feat: migrate to github.com/klauspost/compress/gzip for optimized deflate#3832
wolfeidau merged 1 commit intomainfrom
feat_use_klauspost_compress

Conversation

@wolfeidau
Copy link
Copy Markdown
Member

@wolfeidau wolfeidau commented Apr 19, 2026

Description

Switch to a more optimized version of deflate in the log chunk uploader.

Context

From the readme of this library:

Typical speed is about 2x of the standard library packages.

This package is already an indirect dependency of the project as it is also used by connectrpc.

Changes

This change switches to a more optimized version of deflate in the log chunk uploader.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Disclosures / Credits

I did not use AI tools at all

…late

This change switches to a more optimized version of deflate in the log chunk uploader.

From the readme of this library:

> Typical speed is about 2x of the standard library packages.

This package is already an indirect dependency of the project as it is also used by connectrpc.
@wolfeidau wolfeidau force-pushed the feat_use_klauspost_compress branch from c5563d5 to 2373d19 Compare April 19, 2026 09:43
@wolfeidau wolfeidau marked this pull request as ready for review April 19, 2026 09:43
@wolfeidau wolfeidau requested review from a team as code owners April 19, 2026 09:43
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop in replacement, so nice 👍🏿

@wolfeidau wolfeidau merged commit 7337d7b into main Apr 20, 2026
3 checks passed
@wolfeidau wolfeidau deleted the feat_use_klauspost_compress branch April 20, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants