Merged
Conversation
moskyb
force-pushed
the
remove-deprecated-flags
branch
from
e361d99 to
9d7a710
Compare
DrJosh9000
added a commit
that referenced
this pull request
Apr 20, 2026
Remove deprecated CLI flags
DrJosh9000
added a commit
that referenced
this pull request
Apr 22, 2026
Remove deprecated CLI flags
DrJosh9000
added a commit
that referenced
this pull request
Apr 22, 2026
Remove deprecated CLI flags
DrJosh9000
added a commit
that referenced
this pull request
Apr 23, 2026
Remove deprecated CLI flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the agent, we have a bunch of flags that have been deprecated (and emitting warnings whenever they're used) for a good long while. We're doing v4! Let's throw em out the window.
Changes
Removed the following flags:
agent_start.go:--meta-data,--meta-data-ec2,--meta-data-ec2-tags,--meta-data-gcp,--no-automatic-ssh-fingerprint-verification,--tags-from-ec2,--tags-from-gcp,--disconnect-after-job-timeout,--kubernetes-log-collection-grace-period,artifact_upload.go:--follow-symlinksglobal.go:--kubernetes-log-collection-grace-periodTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Ctrl-F was instrumental to me in this work.