Merged
Conversation
8393fbd to
cbd8485
Compare
DrJosh9000
approved these changes
Apr 20, 2026
Contributor
DrJosh9000
left a comment
There was a problem hiding this comment.
LGTM with one style comment split over two suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We were seeing a startup race in the
pty-rawpath.The child process was being started before the PTY master was put into raw mode, so output written immediately on startup could still be processed with the default PTY line discipline. When that happened,
\nwas rewritten to\r\n, which madeTestProcessOutputPTY_PTYRawExperimentfail intermittently.Testing