Skip to content

chore: add cleanroom config#3840

Draft
lox wants to merge 2 commits intomainfrom
chore/add-cleanroom-config
Draft

chore: add cleanroom config#3840
lox wants to merge 2 commits intomainfrom
chore/add-cleanroom-config

Conversation

@lox
Copy link
Copy Markdown
Contributor

@lox lox commented Apr 20, 2026

Draft

This PR is stacked on top of #3839 and should not be merged until that PR lands first.

Summary

Add a repo-level cleanroom.yaml based on the existing Buildkite Agent example in the cleanroom repo.

This gives the agent repo a checked-in cleanroom policy for running inside a sandbox with deny-by-default egress, explicit mise bootstrap, and cached Go module dependency warmup.

Changes

  • add cleanroom.yaml at the repo root
  • copy the policy from ../cleanroom/examples/buildkite-agent/cleanroom.yaml
  • update the dependency cache key to use mise.toml instead of .mise.toml
  • enable default repo bootstrap so cleanroom exec -- mise ... works from this checkout

Why

This keeps the cleanroom policy alongside the repo it is meant to run, instead of only existing as an external example.

It also depends on the earlier mise.toml rename in #3839, since the dependency-stage cache key now points at mise.toml.

Testing

  • cleanroom policy validate
  • cleanroom exec -- mise x -- go version

@lox lox requested review from a team as code owners April 20, 2026 09:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 173aefe748

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cleanroom.yaml Outdated
@lox lox marked this pull request as draft April 20, 2026 09:55
Base automatically changed from chore/mise-tasks to main April 20, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant