Draft
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 173aefe748
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft
This PR is stacked on top of #3839 and should not be merged until that PR lands first.
Summary
Add a repo-level
cleanroom.yamlbased on the existing Buildkite Agent example in thecleanroomrepo.This gives the agent repo a checked-in cleanroom policy for running inside a sandbox with deny-by-default egress, explicit
misebootstrap, and cached Go module dependency warmup.Changes
cleanroom.yamlat the repo root../cleanroom/examples/buildkite-agent/cleanroom.yamlmise.tomlinstead of.mise.tomlcleanroom exec -- mise ...works from this checkoutWhy
This keeps the cleanroom policy alongside the repo it is meant to run, instead of only existing as an external example.
It also depends on the earlier
mise.tomlrename in #3839, since the dependency-stage cache key now points atmise.toml.Testing
cleanroom policy validatecleanroom exec -- mise x -- go version