fix: Make TestChunksIntervalSeconds less flaky#3850
Merged
DrJosh9000 merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
e0f37a2 to
f3f8117
Compare
zhming0
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a flaky test.
Context
https://buildkite.com/organizations/buildkite/analytics/suites/buildkite-agent/tests/8503693e-4ff1-8a30-9887-f177a8175585?query=TestChunksIntervalSeconds
Changes
Check for a range of possible values, and update the comments.
A few other flourishes while I'm here:
t.Runtwice witht.Parallel. Because the two values are not actually compared against each other, even though that's what the old subtest name implies.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Spite and keyboards.