fix: Flakes in shell_test.go due to missing signal grace period#3854
Merged
DrJosh9000 merged 1 commit intomainfrom Apr 23, 2026
Merged
fix: Flakes in shell_test.go due to missing signal grace period#3854DrJosh9000 merged 1 commit intomainfrom
DrJosh9000 merged 1 commit intomainfrom
Conversation
DrJosh9000
force-pushed
the
fix-flaky-missing-signal-grace-period
branch
from
86b18de to
93b55cc
Compare
zhming0
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the command exits 'killed' when it should be something else. The missing (0) signal grace period causes a race on whether the interrupt or kill is sent.
Context
Flakiness introduced in #3814.
Changes
Add a 10 second signal grace period to
TestContextCancelInteruptsandTestInterrupt.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Found it, fixed it, tested it myself.