Conversation
1196543 to
4184b9c
Compare
buildkate
reviewed
May 1, 2026
buildkate
approved these changes
May 1, 2026
Contributor
buildkate
left a comment
There was a problem hiding this comment.
small nit in comments, but otherwise approved
Co-authored-by: Kate Sy <kate.sy@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
BUILDKITE_TRACING_BACKEND=opentelemetryis configured, the bootstrap process initialises a TracerProvider and creates spans for each job phase (artifact-upload, etc.). However, subcommands likebuildkite-agent artifact uploadrun as separate OS processes and never initialised their own TracerProvider, so even thoughTRACEPARENTandBUILDKITE_TRACING_BACKENDwere present in their environment, no spans were emitted. The executor's phase spans were not visible internally.Context
https://linear.app/buildkite/issue/A-1168/add-automatic-tracing-to-cli-subcommands-artifact-upload-pipeline
Changes
internal/job/tracing.go — extracted InitOTelTracerProvider as a standalone exported function; startTracingOpenTelemetry now delegates to it
clicommand/global.go — setupLoggerAndConfig now initialises a TracerProvider and extracts TRACEPARENT/TRACESTATE into context when running as a subprocess of a traced job
Every subcommand (
artifact upload,pipeline upload, etc.) gets tracing for free.ctx, span := otel.Tracer("buildkite-agent").Start(ctx, "<sub-command-name>")create a new span named after the sub-command-name. Because ctx already has the parent trace context extracted from
TRACEPARENT, OTel automatically makes this span a child of the executor's span.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Grafana screenshots:


Disclosures / Credits
Implementation was carried out in consultation with Claude