Skip to content

docs: mention BUILDKITE_S3_PROFILE in artifact upload help#3869

Merged
moskyb merged 2 commits intobuildkite:mainfrom
mastermanas805:fix/3636-document-s3-profile
May 5, 2026
Merged

docs: mention BUILDKITE_S3_PROFILE in artifact upload help#3869
moskyb merged 2 commits intobuildkite:mainfrom
mastermanas805:fix/3636-document-s3-profile

Conversation

@mastermanas805
Copy link
Copy Markdown
Contributor

@mastermanas805 mastermanas805 commented Apr 29, 2026

Description

Documents BUILDKITE_S3_PROFILE in the artifact upload command help text. Verified behavior in internal/artifact/s3.go: cmp.Or(BUILDKITE_S3_PROFILE, AWS_PROFILE) so BUILDKITE_S3_PROFILE takes precedence.

Fixes #3636

The external buildkite.com docs site lives in a different repo; this PR only adds the in-tree CLI help.

Testing

  • go test ./...
  • go tool gofumpt -extra -w . (no-op for docs)

Disclosures / Credits

Used Claude Code (Opus 4.7) to map the docs surface and draft wording. Reviewed.

@mastermanas805 mastermanas805 marked this pull request as ready for review April 29, 2026 11:40
@mastermanas805 mastermanas805 requested review from a team as code owners April 29, 2026 11:40
Copy link
Copy Markdown
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mastermanas805
Copy link
Copy Markdown
Contributor Author

HI @moskyb, I have 2 more PRs waiting for review #3871 #3870 I request you to assist

@moskyb moskyb enabled auto-merge May 5, 2026 05:15
@moskyb moskyb merged commit 272a94a into buildkite:main May 5, 2026
3 checks passed
@mastermanas805 mastermanas805 deleted the fix/3636-document-s3-profile branch May 5, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document BUILDKITE_S3_PROFILE with v3.111.0 and above.

2 participants