Preserve percent sequences in JSON job logs#3877
Merged
DrJosh9000 merged 1 commit intobuildkite:mainfrom May 3, 2026
Merged
Conversation
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
DrJosh9000
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JSONJobLogger.Writecurrently passes job output directly toLogger.Info.Logger.Infotreats its first argument as a Go format string, so job output containing a percent sequence can be rewritten before it reaches the JSONmsgfield.This PR changes
JSONJobLogger.Writeto pass the job output as a%sargument instead. That keeps literal output such asReceiving objects: 0% (1/140)unchanged.Context
We observed JSON job logs where literal percent sequences in command output were changed by Go formatting before log consumers saw them.
Changes
JSONJobLogger.Write.%.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I used Codex to inspect the logging path, make this small patch, and run the local tests.