Remove header times, ANSI timestamps only and always#3899
Merged
Conversation
moskyb
reviewed
May 7, 2026
| default: | ||
| // processWriter -> {pw, outputWriter}; | ||
| // pw -> pr -> process.Scanner -> headerTimesStreamer | ||
| default: // neither ANSI timestamps nor plaintext timestamps |
Contributor
There was a problem hiding this comment.
should we enforce that everything have ANSI timestamps?
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
remove-header-times
branch
from
e058695 to
cf39df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Header times no longer bring joy.
Timestamps disabled no longer brings joy.
Plaintext timestamps never brought joy in the first place.
ANSI timestamps only and always!
Context
https://buildkite-corp.slack.com/archives/C06J07P1TKM/p1778112393905589
Changes
Remove the header times streamer.
Remove the flags for disabling ANSI timestamps and enabling plaintext timestamps.
Remove the somewhat confusing IO indirection in the job runner that enabled having three different timestamping modes with or without header times.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I used a Keyboardio Atreus to type the changes.