feat(terraform): add modular linux ci stack and network module#87
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 805ba7c46c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| repo_url = "git@github.com:buildkite/cleanroom.git" | ||
| repo_ref = "main" | ||
| setup_script_path = "scripts/bootstrap-linux-buildkite-agent.sh" |
There was a problem hiding this comment.
Point setup_script_path to an existing script
terraform.tfvars.example sets setup_script_path to scripts/bootstrap-linux-buildkite-agent.sh, but that script is not present in this repository (only scripts/install.sh exists), and the userdata bootstrap explicitly exits when the configured script path is missing. Because the README tells users to copy this example file, this causes a fresh CI environment to come up with a failed bootstrap on first boot.
Useful? React with 👍 / 👎.
Summary
infra/terraform/modules/networkmodule for VPC, public/private subnets, IGW, NAT, and routinginfra/terraform/modules/linux-cimodule for a private Linux CI host, IAM/SSM access, and bootstrap handoff script executioninfra/terraform/envs/cias the composition root that wiresmodules/networkandmodules/linux-citerraform.tfvars/example values for the CI environmentmisetool management in.mise.tomlValidation
mise x -- terraform fmt -recursive infra/terraformmise x -- terraform -chdir=infra/terraform/envs/ci init -backend=falsemise x -- terraform -chdir=infra/terraform/envs/ci validate