feat: add singleflight-based download deduplication for concurrent requests#23
Merged
Conversation
Member
wolfeidau
commented
Feb 7, 2026
wolfeidau
commented
- feat: add singleflight-based download deduplication for concurrent requests
- fix: correct singleflight Forget behavior and extract shared download helpers
…quests - Add download package with Downloader type wrapping golang.org/x/sync/singleflight - Uses DoChan with detached context so caller timeouts don't cancel in-flight downloads - Integrate into all protocol handlers (goproxy, npm, oci, pypi, maven, rubygems) - Wire shared Downloader instance through server configuration - Refactor goproxy handleZip to download-then-serve, eliminating double-fetch
… helpers - Only call Forget when the download itself failed, not when the caller's context timed out, preventing cancellation of in-flight downloads for other waiters - Fix goproxy fetchAndStoreZip returning zero size by using temp file pattern to track bytes written - Fix OCI handler using == instead of errors.Is for ErrNotFound - Remove unused logger field and WithLogger option from Downloader - Extract HandleResult, ServeFromStore, and ForgetOnDownloadError helpers into download/serve.go, reducing ~35 lines per handler to ~12 - Add tests for ForgetOnDownloadError context-aware behavior
…nternal helpers - Replace 11-parameter HandleResult with HandleResultParams struct for self-documenting call sites - Unexport forgetOnDownloadError and handleDownloadError since they are only used within HandleResult - Remove IsNotFoundFunc type alias in favor of inline func(error) bool - Add default 404 handler when NotFoundHandler is nil (5 of 6 callers used the same pattern)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.