refactor: distinguish unreferenced blobs from orphan blobs in GC and harden error handling#32
Merged
Merged
Conversation
Member
wolfeidau
commented
Feb 12, 2026
wolfeidau
commented
- Add UnreferencedBlobsDeleted field to GC Result, separating from OrphanBlobsDeleted
- Add corresponding OTel metric for unreferenced blob deletions
- Return errors from metaDB.PutBlob instead of silently ignoring them
- Validate blob hashes with isValidHexHash in extractHashFromKey
- Ignore backend.ErrNotFound when deleting blobs during GC
- Update tests for new field names and add TestExtractHashFromKey
…harden error handling - Add UnreferencedBlobsDeleted field to GC Result, separating from OrphanBlobsDeleted - Add corresponding OTel metric for unreferenced blob deletions - Return errors from metaDB.PutBlob instead of silently ignoring them - Validate blob hashes with isValidHexHash in extractHashFromKey - Ignore backend.ErrNotFound when deleting blobs during GC - Update tests for new field names and add TestExtractHashFromKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.