refactor: reduce metrics cardinality and set protocol via middleware#34
Merged
Conversation
- Split HTTP metrics into shared SLO counters (protocol, status_class, cache_result) and a detail counter that includes endpoint - Add WithProtocol middleware to set protocol at route mount time, replacing path-based derivation in RecordHTTP - Drop method label from all metrics and move endpoint out of shared metrics - Default cache_result to "bypass", add "na" for internal routes - Remove dead alreadyInitialized code from InitMetrics - Add local dev stack: Grafana dashboards, Prometheus config, Procfile
- Add tags_test.go covering InjectTags defaults, setter round-trips, and pointer visibility - Add metrics_test.go covering RecordHTTP shared vs detail metric split and StatusClass - Remove TLS from dev Procfile, Prometheus, and Grafana for Docker container access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.