fix: add blob retention floor to GC and replace dead --cache-ttl flag#40
Merged
Conversation
GC phase 2 previously deleted all blobs with RefCount == 0 on every hourly run, regardless of how recently they were downloaded. This caused ~233 blobs (1.26 GB) to be swept in a single run shortly after jobs completed, since envelope expiry drops RefCount to zero and GC fires within the hour. * Add BlobRetentionTTL to gc.Config: blobs are only deleted when max(CachedAt, LastAccess) + retention < now, giving a sliding window analogous to S3-FIFO's second-chance mechanism * Add before time.Time parameter to GetUnreferencedBlobs (zero = no floor, preserving existing behaviour) * Replace unwired --cache-ttl flag (default 168h, connected to nothing) with --blob-retention (default 24h, wired to GC) * Suppress /metrics and /healthz request logs to reduce scraper noise * Switch dev log format to JSON and tee to dev/data/logs/content-cache.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC phase 2 previously deleted all blobs with RefCount == 0 on every hourly run, regardless of how recently they were downloaded. This caused ~233 blobs (1.26 GB) to be swept in a single run shortly after jobs completed, since envelope expiry drops RefCount to zero and GC fires within the hour.